Fix RFM date range consistency

backend/test/analyticsService.test.js

@@ -2,12 +2,15 @@ const assert = require('node:assert/strict');
 const test = require('node:test');
 
 const {
+    buildRfmClients,
     buildRfmSegments,
     buildDateFilter,
+    getRfmAnalytics,
     getRfmSegment,
     normalizeDateParam,
     scoreTertile
 } = require('../services/analyticsService');
+const { pool } = require('../db');
 
 test('normalizeDateParam accepts strict ISO dates', () => {
     assert.equal(normalizeDateParam('2026-05-28'), '2026-05-28');
@@ -29,6 +32,46 @@ test('buildDateFilter builds bounded date predicates', () => {
     );
 });
 
+test('buildDateFilter builds Hoje as an inclusive single-day date predicate', () => {
+    const filter = buildDateFilter({ start: '2026-06-15', end: '2026-06-15' });
+
+    assert.deepEqual(filter.params, ['2026-06-15', '2026-06-15']);
+    assert.equal(
+        filter.whereClause,
+        'WHERE data_pedido_date IS NOT NULL AND data_pedido_date >= $1::date AND data_pedido_date <= $2::date'
+    );
+});
+
+test('buildDateFilter builds Ontem as an inclusive single-day date predicate', () => {
+    const filter = buildDateFilter({ start: '2026-06-14', end: '2026-06-14' });
+
+    assert.deepEqual(filter.params, ['2026-06-14', '2026-06-14']);
+    assert.equal(
+        filter.whereClause,
+        'WHERE data_pedido_date IS NOT NULL AND data_pedido_date >= $1::date AND data_pedido_date <= $2::date'
+    );
+});
+
+test('buildDateFilter builds Ultimos 7 dias as an inclusive calendar range', () => {
+    const filter = buildDateFilter({ start: '2026-06-09', end: '2026-06-15' });
+
+    assert.deepEqual(filter.params, ['2026-06-09', '2026-06-15']);
+    assert.equal(
+        filter.whereClause,
+        'WHERE data_pedido_date IS NOT NULL AND data_pedido_date >= $1::date AND data_pedido_date <= $2::date'
+    );
+});
+
+test('buildDateFilter builds custom single-day ranges inclusively', () => {
+    const filter = buildDateFilter({ start: '2026-06-10', end: '2026-06-10' });
+
+    assert.deepEqual(filter.params, ['2026-06-10', '2026-06-10']);
+    assert.equal(
+        filter.whereClause,
+        'WHERE data_pedido_date IS NOT NULL AND data_pedido_date >= $1::date AND data_pedido_date <= $2::date'
+    );
+});
+
 test('buildDateFilter ignores invalid bounds', () => {
     const filter = buildDateFilter({ start: 'invalid', end: '2026-05-28' });
 
@@ -77,3 +120,52 @@ test('buildRfmSegments summarizes segment count and revenue', () => {
     assert.equal(lost.count, 1);
     assert.equal(lost.totalRevenue, 25);
 });
+
+test('buildRfmClients keeps a yesterday buyer in the same high-recency segment when it is the only qualifying client', () => {
+    const sevenDayClients = buildRfmClients([
+        { name: 'Cliente Ontem', phone: '1', monetary: 500, frequency: 2, quantityPurchased: 2, lastPurchaseDate: '2026-06-14', recencyDays: 1 }
+    ]);
+    const yesterdayClients = buildRfmClients([
+        { name: 'Cliente Ontem', phone: '1', monetary: 500, frequency: 2, quantityPurchased: 2, lastPurchaseDate: '2026-06-14', recencyDays: 0 }
+    ]);
+
+    assert.equal(sevenDayClients[0].segmentKey, 'champions');
+    assert.equal(yesterdayClients[0].segmentKey, 'champions');
+    assert.equal(sevenDayClients[0].phone, yesterdayClients[0].phone);
+});
+
+test('getRfmAnalytics calculates recency against selected range end date', async () => {
+    const originalQuery = pool.query;
+    const calls = [];
+
+    pool.query = async (sql, params) => {
+        calls.push({ sql, params });
+        return {
+            rows: [
+                {
+                    name: 'Cliente Ontem',
+                    phone: '1',
+                    monetary: 500,
+                    frequency: 2,
+                    quantity_purchased: 2,
+                    last_purchase_date: '2026-06-14',
+                    recency_days: params[2] === '2026-06-14' ? 0 : 1
+                }
+            ]
+        };
+    };
+
+    try {
+        const sevenDays = await getRfmAnalytics({ start: '2026-06-09', end: '2026-06-15' });
+        const yesterday = await getRfmAnalytics({ start: '2026-06-14', end: '2026-06-14' });
+
+        assert.match(calls[0].sql, /\(\$3::date - MAX\(data_pedido_date\)\)::int/);
+        assert.deepEqual(calls[0].params, ['2026-06-09', '2026-06-15', '2026-06-15']);
+        assert.deepEqual(calls[1].params, ['2026-06-14', '2026-06-14', '2026-06-14']);
+        assert.equal(sevenDays.clients[0].segmentKey, 'champions');
+        assert.equal(yesterday.clients[0].segmentKey, 'champions');
+        assert.equal(yesterday.clients[0].recencyDays, 0);
+    } finally {
+        pool.query = originalQuery;
+    }
+});