Revert "Optimize RFV all-period analytics"
This reverts commit 7fb2507f53.
This commit is contained in:
@@ -262,14 +262,12 @@ const getClientAnalytics = async (range = {}) => {
|
||||
|
||||
const getRfmAnalytics = async (range = {}) => {
|
||||
const { params, whereClause } = buildDateFilter(range);
|
||||
const normalizedStart = normalizeDateParam(range.start);
|
||||
const normalizedEnd = normalizeDateParam(range.end);
|
||||
const periodRecencyReferenceDate = normalizedEnd ? `$${params.length}::date` : 'CURRENT_DATE';
|
||||
const recencyReferenceDate = normalizedEnd ? '$1::date' : 'CURRENT_DATE';
|
||||
const historyParams = normalizedEnd ? [normalizedEnd] : [];
|
||||
const usePeriodAsHistory = !normalizedStart || normalizedStart <= '2000-01-01';
|
||||
|
||||
const periodQuery = pool.query(`
|
||||
const [periodResult, historyResult] = await Promise.all([
|
||||
pool.query(`
|
||||
SELECT
|
||||
${CUSTOMER_KEY_SQL} as customer_key,
|
||||
MAX(cliente_nome) as name,
|
||||
@@ -277,15 +275,13 @@ const getRfmAnalytics = async (range = {}) => {
|
||||
COALESCE(SUM(quantidade * valor_unitario), 0) as monetary,
|
||||
COUNT(DISTINCT COALESCE(NULLIF(pedido_id, ''), data_pedido || '_' || valor_pedido::text))::int as frequency,
|
||||
COALESCE(SUM(quantidade), 0) as quantity_purchased,
|
||||
MAX(data_pedido_date) as last_purchase_date,
|
||||
GREATEST((${periodRecencyReferenceDate} - MAX(data_pedido_date))::int, 0) as recency_days
|
||||
MAX(data_pedido_date) as last_purchase_date
|
||||
FROM orders
|
||||
${whereClause}
|
||||
GROUP BY customer_key
|
||||
ORDER BY monetary DESC;
|
||||
`, params);
|
||||
|
||||
const historyQuery = usePeriodAsHistory ? null : pool.query(`
|
||||
`, params),
|
||||
pool.query(`
|
||||
SELECT
|
||||
${CUSTOMER_KEY_SQL} as customer_key,
|
||||
MAX(cliente_nome) as name,
|
||||
@@ -299,15 +295,10 @@ const getRfmAnalytics = async (range = {}) => {
|
||||
WHERE data_pedido_date IS NOT NULL
|
||||
AND data_pedido_date <= ${recencyReferenceDate}
|
||||
GROUP BY customer_key;
|
||||
`, historyParams);
|
||||
`, historyParams)
|
||||
]);
|
||||
|
||||
const [periodResult, historyResult] = historyQuery
|
||||
? await Promise.all([periodQuery, historyQuery])
|
||||
: [await periodQuery, null];
|
||||
|
||||
const historyRows = historyResult ? historyResult.rows : periodResult.rows;
|
||||
|
||||
const historyClients = buildRfmClients(historyRows.map(row => ({
|
||||
const historyClients = buildRfmClients(historyResult.rows.map(row => ({
|
||||
customerKey: row.customer_key,
|
||||
name: row.name,
|
||||
phone: row.phone || '',
|
||||
|
||||
@@ -197,7 +197,7 @@ test('getRfmAnalytics classifies period buyers by history through the selected r
|
||||
|
||||
pool.query = async (sql, params) => {
|
||||
calls.push({ sql, params });
|
||||
const isHistoryQuery = sql.includes('AND data_pedido_date <= $1::date');
|
||||
const isHistoryQuery = sql.includes('recency_days');
|
||||
const referenceDate = params[0];
|
||||
|
||||
if (isHistoryQuery) {
|
||||
@@ -282,48 +282,3 @@ test('getRfmAnalytics classifies period buyers by history through the selected r
|
||||
pool.query = originalQuery;
|
||||
}
|
||||
});
|
||||
|
||||
test('getRfmAnalytics reuses period rows as RFV history for all-period ranges', async () => {
|
||||
const originalQuery = pool.query;
|
||||
const calls = [];
|
||||
|
||||
pool.query = async (sql, params) => {
|
||||
calls.push({ sql, params });
|
||||
return {
|
||||
rows: [
|
||||
{
|
||||
customer_key: '1',
|
||||
name: 'Cliente Frequente',
|
||||
phone: '1',
|
||||
monetary: 5000,
|
||||
frequency: 20,
|
||||
quantity_purchased: 20,
|
||||
last_purchase_date: '2026-06-14',
|
||||
recency_days: 1
|
||||
},
|
||||
{
|
||||
customer_key: '2',
|
||||
name: 'Cliente Antigo',
|
||||
phone: '2',
|
||||
monetary: 50,
|
||||
frequency: 1,
|
||||
quantity_purchased: 1,
|
||||
last_purchase_date: '2026-01-01',
|
||||
recency_days: 165
|
||||
}
|
||||
]
|
||||
};
|
||||
};
|
||||
|
||||
try {
|
||||
const result = await getRfmAnalytics({ start: '2000-01-01', end: '2026-06-15' });
|
||||
|
||||
assert.equal(calls.length, 1);
|
||||
assert.match(calls[0].sql, /\(\$2::date - MAX\(data_pedido_date\)\)::int/);
|
||||
assert.deepEqual(calls[0].params, ['2000-01-01', '2026-06-15']);
|
||||
assert.equal(result.clients.length, 2);
|
||||
assert.equal(result.segments.reduce((total, segment) => total + segment.count, 0), 2);
|
||||
} finally {
|
||||
pool.query = originalQuery;
|
||||
}
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user